lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Mar 2016 09:54:05 +0100 From: Nicolas Ferre <nicolas.ferre@...el.com> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>, David Miller <davem@...hat.com> CC: <netdev@...r.kernel.org> Subject: Re: [PATCH] macb: fix PHY reset Le 22/03/2016 22:33, Sergei Shtylyov a écrit : > On 03/22/2016 11:07 PM, David Miller wrote: > >>> On 03/22/2016 10:27 PM, Sergei Shtylyov wrote: >>> >>>> The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and >>>> 1, as >>>> a result the PHY isn't really put back into reset state in >>>> macb_remove(). >>>> Moreover, the driver assumes that something else has set the GPIO >>>> direction >>>> to output, so if it has not, the PHY wouldn't be taken out of reset in >>> >>> s/wouldn't/may not/, sorry. Do I need to resend? >> >> No need, I fixed it up by hand. >> >> Applied, thanks. > > Oops, forgot another tag: > > Fixes: 270c499f0993 ("net/macb: Update device tree binding for resetting PHY > using GPIO") > > Too late probably... :-( Too late also: Acked-by: Nicolas Ferre <nicolas.ferre@...el.com> Thanks Sergei! Bye, -- Nicolas Ferre
Powered by blists - more mailing lists