netdev - Re: [PATCH] netlabel: fix a problem with netlbl_secattr_catmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Mar 2016 11:17:28 -0400
From:	Paul Moore <paul@...l-moore.com>
To:	netdev@...r.kernel.org
Cc:	selinux@...ho.nsa.gov, Janak Desai <Janak.Desai@...i.gatech.edu>,
	Paul Moore <pmoore@...hat.com>
Subject: Re: [PATCH] netlabel: fix a problem with netlbl_secattr_catmap_setrng()

On Mon, Mar 28, 2016 at 11:10 AM, Paul Moore <pmoore@...hat.com> wrote:
> From: Janak Desai <Janak.Desai@...i.gatech.edu>
>
> We try to be clever and set large chunks of the bitmap at once, when
> possible; unfortunately we weren't very clever when we wrote the code
> and messed up the if-conditional.  Fix this bug and restore proper
> operation.
>
> Signed-off-by: Janak Desai <Janak.Desai@...i.gatech.edu>
> Signed-off-by: Paul Moore <paul@...l-moore.com>
> ---
>  net/netlabel/netlabel_kapi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

DaveM, I'm planning on carrying this in selinux#next unless you really
want to this to go to Linus via the netdev tree.

> diff --git a/net/netlabel/netlabel_kapi.c b/net/netlabel/netlabel_kapi.c
> index 28cddc8..1325776 100644
> --- a/net/netlabel/netlabel_kapi.c
> +++ b/net/netlabel/netlabel_kapi.c
> @@ -677,7 +677,7 @@ int netlbl_catmap_setrng(struct netlbl_lsm_catmap **catmap,
>         u32 spot = start;
>
>         while (rc == 0 && spot <= end) {
> -               if (((spot & (BITS_PER_LONG - 1)) != 0) &&
> +               if (((spot & (BITS_PER_LONG - 1)) == 0) &&
>                     ((end - spot) > BITS_PER_LONG)) {
>                         rc = netlbl_catmap_setlong(catmap,
>                                                    spot,
>

-- 
paul moore
www.paul-moore.com