netdev - Re: [net-next] bond: output message before setting slave to inactive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 31 Mar 2016 09:23:01 +0800
From:	张胜举 <zhangshengju@...s.chinamobile.com>
To:	"'David Miller'" <davem@...emloft.net>
Cc:	<j.vosburgh@...il.com>, <vfalico@...il.com>,
	<gospo@...ulusnetworks.com>, <netdev@...r.kernel.org>
Subject: Re: [net-next] bond: output message before setting slave to inactive

> From: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> Date: Tue, 29 Mar 2016 06:32:57 +0000
> 
> > This patch moves output message before setting slave to inactive, this
> > will print the correct status of slave device.
> >
> > Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> 
> I think the message is in the appropriate spot wrt. state, so I will not
apply
> this, thanks.

The message will always print 'backup',  since the code set it to inactive
before this output.
I think this will cause a little confused, because even when I detach an
active slave, the output is always 'backup'.

Thanks.