lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 4 Apr 2016 14:22:19 +0200 From: Andrew Lunn <andrew@...n.ch> To: Charles-Antoine Couret <charles-antoine.couret@...vision.fr> Cc: netdev@...r.kernel.org Subject: Re: [PATCH] Marvell phy: add fiber status check for some components On Mon, Apr 04, 2016 at 10:45:42AM +0200, Charles-Antoine Couret wrote: > Hi, > > > Shouldn't you return to page 0, i.e. MII_M1111_COPPER, under all > > conditions? > > I return marvell_read_status() which returns 0 if it hasn't error during the process. > In case of right conditions, my function returns 0 for COPPER part (and FIBER part too). > > It doesn't change the value returned and behavior. Hi Charles Please read my email again. I'm talking about the phy page, not the function return value. Andrew
Powered by blists - more mailing lists