netdev - Re: [PREEMPT-RT] [PATCH] net: mvneta: Remove superfluous SMP function call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 5 Apr 2016 15:32:43 +0200 (CEST)
From:	Anna-Maria Gleixner <anna-maria@...utronix.de>
To:	linux-kernel@...r.kernel.org
cc:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	netdev@...r.kernel.org, rt@...utronix.de
Subject: Re: [PREEMPT-RT] [PATCH] net: mvneta: Remove superfluous SMP function
 call

On Mon, 4 Apr 2016, Anna-Maria Gleixner wrote:

> Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to
> hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and
> CPU_DOWN_PREPARE are processed on the hotplugged cpu. Due to this SMP
> function calls are no longer required.
> 
> Replace smp_call_function_single() with a direct call to
> mvneta_percpu_enable() or mvneta_percpu_disable(). The functions do
> not require to be called with interrupts disabled, therefore the
> smp_call_function_single() calling convention is not preserved.
> 
> Cc: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@...utronix.de>
> ---
>  drivers/net/ethernet/marvell/mvneta.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>

Please do not queue it. Heiko Carstens pointed out a problem: It isn't
ensured, that the callbacks of CPU_DOWN_FAILED are always processed on
the CPU that failed in CPU_DOWN_PREPARE (see
http://marc.info/?l=linux-s390&m=145985621421250&w=2 ). Once this
issue is fixed, I will resend the patch.

Anna-Maria