lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 07 Apr 2016 19:50:27 -0700 From: roopa <roopa@...ulusnetworks.com> To: David Miller <davem@...emloft.net> CC: netdev@...r.kernel.org Subject: Re: mpls's find_outdev() On 4/7/16, 6:41 PM, David Miller wrote: > While auditing something unrelated, I noticed that this function seems > to potentially dev_put() on an error pointer. > > I guess the problem comes from the fact that there are two methods > by which the device pointer is obtained. > > First, inet{,6}_fib_lookup_dev() which uses error pointers. > > Second, dev_get_by_index() which returns a valid device or NULL, > and therefore does not use error pointers. > > If inet{,6}_fib_lookup_dev() returns an error pointer, the !dev check > will not pass and dev_put() will operate on an error pointer and > crash. > > If you agree with my analysis, could you please cook up and test a > fix? > > Thank you! certainly!. I see it. Thanks for catching it. I will test and post a fix in a few hours.
Powered by blists - more mailing lists