lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Apr 2016 19:46:09 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Timur Tabi <timur@...eaurora.org>, netdev@...r.kernel.org, davem@...emloft.net, marek.belisko@...il.com, ujhelyi.m@...il.com, zonque@...il.com Subject: Re: [PATCH] net: phy: at803x: only the AT8030 needs a hardware reset on link change Le 26/04/2016 10:44, Timur Tabi a écrit : > Commit 13a56b44 ("at803x: Add support for hardware reset") added a > work-around for a hardware bug on the AT8030. However, the work-around > was being called for all 803x PHYs, even those that don't need it. > Function at803x_link_change_notify() checks to make sure that it only > resets the PHY on the 8030, but it makes more sense to not call that > function at all if it isn't needed. > > Signed-off-by: Timur Tabi <timur@...eaurora.org> Reviewed-by: Florian Fainelli <f.fainelli@...il.com> This looks nicer indeed! -- Florian
Powered by blists - more mailing lists