netdev - Re: myri10ge: fix sleeping with bh disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Apr 2016 14:21:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sgruszka@...hat.com
Cc:	netdev@...r.kernel.org, hykim@...i.com
Subject: Re: myri10ge: fix sleeping with bh disabled

From: Stanislaw Gruszka <sgruszka@...hat.com>
Date: Mon, 25 Apr 2016 10:59:19 +0200

> napi_disable() can not be called with bh disabled, move locking just
> around myri10ge_ss_lock_napi() .
> 
> Patches fixes following bug:
> 
> [  114.278378] BUG: sleeping function called from invalid context at net/core/dev.c:4383 
> <snip>
> [  114.313712] Call Trace: 
> [  114.314943]  [<ffffffff817010ce>] dump_stack+0x19/0x1b 
> [  114.317673]  [<ffffffff810ce7f3>] __might_sleep+0x173/0x230 
> [  114.320566]  [<ffffffff815b3117>] napi_disable+0x27/0x90 
> [  114.323254]  [<ffffffffa01e437f>] myri10ge_close+0xbf/0x3f0 [myri10ge] 
> 
> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>

Applied.