netdev - Re: [PATCH net-next #2 1/1] pch_gbe: replace private tx ring lock with common netif_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Apr 2016 17:21:56 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	netdev@...r.kernel.org, nikolay@...ulusnetworks.com,
	dvhart@...radead.org, andy.cress@...kontron.com,
	bryan@...setcon.org
Subject: Re: [PATCH net-next #2 1/1] pch_gbe: replace private tx ring lock
 with common netif_tx_lock

From: Francois Romieu <romieu@...zoreil.com>
Date: Wed, 27 Apr 2016 23:29:44 +0200

> pch_gbe_tx_ring.tx_lock is only used in the hard_xmit handler and
> in the transmit completion reaper called from NAPI context.
> 
> Compile-tested only. Potential victims Cced.
> 
> Someone more knowledgeable may check if pch_gbe_tx_queue could
> have some use for a mmiowb.
> 
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> Cc: Darren Hart <dvhart@...radead.org>
> Cc: Andy Cress <andy.cress@...kontron.com>
> Cc: bryan@...setcon.org
> 
> ---
>  Includes Nikolay's fix.

Applied, thank you.