netdev - Re: [PATCH v6 5/6] ARM: dts: stm32f429: Align Ethernet node with new bindings properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Apr 2016 14:01:17 +0200
From:	Maxime Coquelin <mcoquelin.stm32@...il.com>
To:	Alexandre TORGUE <alexandre.torgue@...il.com>,
	Rob Herring <robh@...nel.org>
Cc:	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	netdev@...r.kernel.org,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Joachim Eastwood <manabian@...il.com>, wens@...e.org
Subject: Re: [PATCH v6 5/6] ARM: dts: stm32f429: Align Ethernet node with new
 bindings properties

Hi Alex,

2016-04-25 13:54 GMT+02:00 Alexandre TORGUE <alexandre.torgue@...il.com>:
> This patch aligns clocks names and node reference according to new
> stm32-dwmac glue binding. It also renames Ethernet pinctrl phandle
> (indeed there is no need to add 0 as Ethernet instance as there is only
> one IP in SOC).
>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@...il.com>
>
> diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
> index 35df462..5995998 100644
> --- a/arch/arm/boot/dts/stm32f429.dtsi
> +++ b/arch/arm/boot/dts/stm32f429.dtsi
> @@ -304,7 +304,7 @@
>                                 };
>                         };
>
> -                       ethernet0_mii: mii@0 {
> +                       ethernet_mii: mii@0 {
>                                 pins {
>                                         pinmux = <STM32F429_PG13_FUNC_ETH_MII_TXD0_ETH_RMII_TXD0>,
>                                                  <STM32F429_PG14_FUNC_ETH_MII_TXD1_ETH_RMII_TXD1>,
> @@ -363,13 +363,13 @@
>                         st,mem2mem;
>                 };
>
> -               ethernet0: dwmac@...28000 {
> +               mac: ethernet@...28000 {
>                         compatible = "st,stm32-dwmac", "snps,dwmac-3.50a";
>                         reg = <0x40028000 0x8000>;
>                         reg-names = "stmmaceth";
>                         interrupts = <61>, <62>;
>                         interrupt-names = "macirq", "eth_wake_irq";
> -                       clock-names = "stmmaceth", "tx-clk", "rx-clk";
> +                       clock-names = "stmmaceth", "mac-clk-tx", "mac-clk-rx";

It looks good to me, but I will wait for Rob's ack on the bindings
documentation patch before applying it.

Regards,
Maxime