netdev - Re: [PATCH net] ip_tunnel: fix preempt warning in ip tunnel creation/updating

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 29 Apr 2016 14:11:33 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	pabeni@...hat.com
Cc:	netdev@...r.kernel.org, kuznet@....inr.ac.ru, tgraf@...g.ch,
	pshelar@...ira.com, jbenc@...hat.com, hannes@...essinduktion.org,
	sergei.shtylyov@...entembedded.com, tom@...bertland.com,
	eric.dumazet@...il.com
Subject: Re: [PATCH net] ip_tunnel: fix preempt warning in ip tunnel
 creation/updating

From: Paolo Abeni <pabeni@...hat.com>
Date: Thu, 28 Apr 2016 11:04:51 +0200

> After the commit e09acddf873b ("ip_tunnel: replace dst_cache with generic
> implementation"), a preemption debug warning is triggered on ip4
> tunnels updating; the dst cache helper needs to be invoked in unpreemptible
> context.
> 
> We don't need to load the cache on tunnel update, so this commit fixes
> the warning replacing the load with a dst cache reset, which is
> preempt safe.
> 
> Fixes: e09acddf873b ("ip_tunnel: replace dst_cache with generic
> implementation")
> 
> Reported-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied, thanks Paolo.