netdev - Re: [iproute2 1/1] man: tc-ife.8: man page for ife action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 30 Apr 2016 13:35:07 +0200
From:	Phil Sutter <phil@....cc>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	stephen@...workplumber.org, netdev@...r.kernel.org,
	lucasb@...atatu.com
Subject: Re: [iproute2 1/1] man: tc-ife.8: man page for ife action

On Sat, Apr 30, 2016 at 06:58:04AM -0400, Jamal Hadi Salim wrote:
> From: Lucas Bates <lucasb@...atatu.com>
> 
> Signed-off-by: Lucas Bates <lucasb@...atatu.com>
> Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com>

Acked-by: Phil Sutter <phil@....cc>

Nit-picking on two things below, but merely as a hint - I don't think
they need to be fixed before applying this.

[...]
> +.SH NAME
> +IFE - encapsulate/decapsulate metadata
> +.SH SYNOPSIS
> +.in +8
> +.ti -8
> +.BR tc " ... " "action"
> +.B "ife"

The quotes around 'action' and 'ife' are not necessary. Furthermore,
the two lines can be combined:

> +.I DIRECTION ACTION
> +.RB "[ " dst
> +.IR DMAC " ] "
> +.RB "[ " src
> +.IR SMAC " ] "
> +.RB "[ " type
> +.IR TYPE " ] "
> +.R "[ " 

This adds a trailing whitespace. Checkpatch.pl finds these things. ;)

Thanks, Phil