netdev - Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 1 May 2016 21:53:57 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	David Miller <davem@...emloft.net>
Cc:	nicolas.dichtel@...nd.com, fw@...len.de, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

Thu, Apr 28, 2016 at 05:54:19PM CEST, davem@...emloft.net wrote:
>From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
>Date: Thu, 28 Apr 2016 13:59:34 +0200
>
>> Le 27/04/2016 18:55, David Miller a écrit :
>>> From: Jiri Pirko <jiri@...nulli.us>
>> [snip]
>>>> The difference is that it this tries to allow userspace crap to mirror
>>>> setting user does for bridge/ovs. Basically this looks to me like an
>>>> attempt to enable userspace SDKs and such.
>>> 
>>> +1
>> I don't think so because a userspace can receive all the bridge/ovs settings by
>> mean of netlink mirror, without the need for this driver at all.
>
>You can say whatever you want, but the facilities you are adding to
>this driver enables proprietary userland SDK components.
>
>And this is precisely what we are trying to avoid by having a clean,
>fully featured switch device model in the kernel.
>
>It is against your interestes of upstreaming your driver to continue
>denying what your changes facilitate.

+1

Nicolas, your driver is big a step back. Just do what you need to do,
properly, in kernel. There's a lot of people to help you with that
around.