netdev - Re: [PATCH net-next 4/5] treewide: replace dev->trans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 May 2016 17:03:01 +0530
From:	Mugunthan V N <mugunthanvnm@...com>
To:	Florian Westphal <fw@...len.de>, <netdev@...r.kernel.org>
CC:	<user-mode-linux-devel@...ts.sourceforge.net>,
	<linux-xtensa@...ux-xtensa.org>,
	<linux1394-devel@...ts.sourceforge.net>,
	<linux-rdma@...r.kernel.org>, <MPT-FusionLinux.pdl@...adcom.com>,
	<linux-scsi@...r.kernel.org>, <linux-can@...r.kernel.org>,
	<linux-parisc@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<linux-hams@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<linux-wireless@...r.kernel.org>, <linux-s390@...r.kernel.org>,
	<devel@...verdev.osuosl.org>, <b.a.t.m.a.n@...ts.open-mesh.org>,
	<linux-bluetooth@...r.kernel.org>
Subject: Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update
 with helper

On Tuesday 03 May 2016 08:03 PM, Florian Westphal wrote:
> Replace all trans_start updates with netif_trans_update helper.
> change was done via spatch:
> 
> struct net_device *d;
> @@
> - d->trans_start = jiffies
> + netif_trans_update(d)
> 
> Compile tested only.
> 
> Cc: user-mode-linux-devel@...ts.sourceforge.net
> Cc: linux-xtensa@...ux-xtensa.org
> Cc: linux1394-devel@...ts.sourceforge.net
> Cc: linux-rdma@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Cc: MPT-FusionLinux.pdl@...adcom.com
> Cc: linux-scsi@...r.kernel.org
> Cc: linux-can@...r.kernel.org
> Cc: linux-parisc@...r.kernel.org
> Cc: linux-omap@...r.kernel.org
> Cc: linux-hams@...r.kernel.org
> Cc: linux-usb@...r.kernel.org
> Cc: linux-wireless@...r.kernel.org
> Cc: linux-s390@...r.kernel.org
> Cc: devel@...verdev.osuosl.org
> Cc: b.a.t.m.a.n@...ts.open-mesh.org
> Cc: linux-bluetooth@...r.kernel.org
> Signed-off-by: Florian Westphal <fw@...len.de>
> ---

snip...


> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 0fa75a8..3d4662d 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -1381,7 +1381,7 @@ static netdev_tx_t cpsw_ndo_start_xmit(struct sk_buff *skb,
>  	struct cpsw_priv *priv = netdev_priv(ndev);
>  	int ret;
>  
> -	ndev->trans_start = jiffies;
> +	netif_trans_update(ndev);
>  
>  	if (skb_padto(skb, CPSW_MIN_PACKET_SIZE)) {
>  		cpsw_err(priv, tx_err, "packet pad failed\n");

for cpsw

Acked-by: Mugunthan V N <mugunthanvnm@...com>

Regards
Mugunthan V N