[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 04 May 2016 23:53:08 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: marc@...sta.com
Cc: netdev@...r.kernel.org, ebiederm@...ssion.com
Subject: Re: [PATCH net-next v2] macvtap: add namespace support to the
sysfs device class
From: Marc Angel <marc@...sta.com>
Date: Thu, 5 May 2016 01:33:09 +0100
> On Wed, May 4, 2016 at 9:04 PM, David Miller <davem@...emloft.net> wrote:
>> From: Marc Angel <marc@...sta.com>
>> Date: Tue, 3 May 2016 20:30:54 +0200
>>
>>> @@ -1274,6 +1285,7 @@ static int macvtap_device_event(struct notifier_block *unused,
>>> unsigned long event, void *ptr)
>>> {
>>> struct net_device *dev = netdev_notifier_info_to_dev(ptr);
>>> + const char *tap_name = kasprintf(GFP_KERNEL, "tap%d", dev->ifindex);
>>> struct macvlan_dev *vlan;
>>> struct device *classdev;
>>> dev_t devt;
>>
>> This 'tap_name' buffer seems to be leaked in several code paths.
>
> Sorry about that... V3 should be better.
V3 doesn't apply cleanly to net-next, please respin your patch against
the current tree.
Thanks.
Powered by blists - more mailing lists