netdev - Re: [PATCH net-next] net: vrf: Create FIB tables on link create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 05 May 2016 00:24:48 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dsa@...ulusnetworks.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: vrf: Create FIB tables on link create

From: David Ahern <dsa@...ulusnetworks.com>
Date: Wed,  4 May 2016 21:18:07 -0700

> @@ -372,9 +372,13 @@ static int vrf_rt6_create(struct net_device *dev)
>  	if (!rt6)
>  		goto out;
>  
> -	rt6->dst.output	= vrf_output6;
> -	rt6->rt6i_table = fib6_get_table(net, vrf->tb_id);
>  	dst_hold(&rt6->dst);
> +
> +	rt6->rt6i_table = fib6_new_table(net, vrf->tb_id);
> +	if (!rt6->rt6i_table)
> +		goto out;
> +
> +	rt6->dst.output	= vrf_output6;
>  	vrf->rt6 = rt6;
>  	rc = 0;
>  out:

This leaks rt6.