[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 05 May 2016 10:31:36 +0200
From: Arnd Bergmann <arnd@...db.de>
To: linuxppc-dev@...ts.ozlabs.org
Cc: Yangbo Lu <yangbo.lu@....com>, linux-mmc@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
linux-i2c@...r.kernel.org, iommu@...ts.linux-foundation.org,
netdev@...r.kernel.org, Mark Rutland <mark.rutland@....com>,
ulf.hansson@...aro.org, Russell King <linux@....linux.org.uk>,
Bhupesh Sharma <bhupesh.sharma@...escale.com>,
Joerg Roedel <joro@...tes.org>,
Santosh Shilimkar <ssantosh@...nel.org>, leoyang.li@....com,
Scott Wood <oss@...error.net>,
Rob Herring <robh+dt@...nel.org>,
Claudiu Manoil <claudiu.manoil@...escale.com>,
Kumar Gala <galak@...eaurora.org>, xiaobo.xie@....com,
Qiang Zhao <qiang.zhao@....com>
Subject: Re: [v10, 7/7] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0
On Thursday 05 May 2016 11:12:30 Yangbo Lu wrote:
>
> + fsl_guts_init();
> + svr = fsl_guts_get_svr();
> + if (svr) {
> + esdhc->soc_ver = SVR_SOC_VER(svr);
> + esdhc->soc_rev = SVR_REV(svr);
> + } else {
> + dev_err(&pdev->dev, "Failed to get SVR value!\n");
> + }
> +
>
Sorry for jumping in again after not participating in the discussion for the
past few versions.
What happened to my suggestion of making this a platform-independent interface
to avoid the link time dependency?
Specifically, why not add an exported function to drivers/base/soc.c that
uses glob_match() for comparing a string in the device driver to the ID
of the SoC that is set by whatever SoC identifying driver the platform
has?
Arnd
Powered by blists - more mailing lists