lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 6 May 2016 15:28:25 +0100 From: Edward Cree <ecree@...arflare.com> To: Stephen Hemminger <stephen@...workplumber.org>, netdev <netdev@...r.kernel.org> CC: "John W. Linville" <linville@...driver.com> Subject: [PATCH iproute2] geneve: fix IPv6 remote address reporting Since we can only configure unicast, we probably want to be able to display unicast, rather than multicast. Fixes: 906ac5437ab8 ("geneve: add support for IPv6 link partners") Signed-off-by: Edward Cree <ecree@...arflare.com> --- I'm assuming this is what was intended, but tbh I don't know why we need to check for multicast on the display side at all, rather than just displaying whatever the kernel gives us. ip/iplink_geneve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iplink_geneve.c b/ip/iplink_geneve.c index 84d948f..65af6b3 100644 --- a/ip/iplink_geneve.c +++ b/ip/iplink_geneve.c @@ -204,7 +204,7 @@ static void geneve_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[]) memcpy(&addr, RTA_DATA(tb[IFLA_GENEVE_REMOTE6]), sizeof(struct in6_addr)); if (memcmp(&addr, &in6addr_any, sizeof(addr)) != 0) { - if (IN6_IS_ADDR_MULTICAST(&addr)) + if (!IN6_IS_ADDR_MULTICAST(&addr)) fprintf(f, "remote %s ", format_host(AF_INET6, sizeof(struct in6_addr), &addr)); } -- 2.4.3
Powered by blists - more mailing lists