netdev - RE: [PATCH v2 0/3] net: ethtool: add ethtool_op_{get|set}_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 May 2016 01:57:56 +0000
From:	Fugang Duan <fugang.duan@....com>
To:	Philippe Reynes <tremyfr@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"ben@...adent.org.uk" <ben@...adent.org.uk>,
	"kan.liang@...el.com" <kan.liang@...el.com>,
	"decot@...glers.com" <decot@...glers.com>,
	"aduyck@...antis.com" <aduyck@...antis.com>,
	"jiri@...lanox.com" <jiri@...lanox.com>,
	"jacob.e.keller@...el.com" <jacob.e.keller@...el.com>,
	"tom@...bertland.com" <tom@...bertland.com>,
	"andrew@...n.ch" <andrew@...n.ch>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 0/3] net: ethtool: add
 ethtool_op_{get|set}_link_ksettings

Fom: Philippe Reynes <tremyfr@...il.com> Sent: Monday, May 09, 2016 5:45 AM
> To: Fugang Duan <fugang.duan@....com>; davem@...emloft.net;
> ben@...adent.org.uk; kan.liang@...el.com; decot@...glers.com;
> aduyck@...antis.com; jiri@...lanox.com; jacob.e.keller@...el.com;
> tom@...bertland.com; andrew@...n.ch
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Philippe Reynes
> <tremyfr@...il.com>
> Subject: [PATCH v2 0/3] net: ethtool: add ethtool_op_{get|set}_link_ksettings
> 
> Ethtool callbacks {get|set}_link_ksettings may be the same for many drivers. So
> we add two generics callbacks ethtool_op_{get|set}_link_ksettings.
> 
> To use those generics callbacks, the ethernet driver must use the pointer
> phydev contained in struct net_device, and not use a private structure to store
> this pointer.
> 
> Changelog:
> v2:
> - use generic function instead of macro
> - ethernet driver use the pointer phydev provided by struct net_device
>   Those idea were provided by Ben Hutchings,
>   and Florian Fainelli acknowledge them.
> 
> Philippe Reynes (3):
>   net: core: ethtool: add ethtool_op_{get|set}_link_ksettings
>   net: ethernet: fec: use phydev from struct net_device
>   net: ethernet: fec: use ethtool_op_{get|set}_link_ksettings
> 
>  drivers/net/ethernet/freescale/fec.h      |    1 -
>  drivers/net/ethernet/freescale/fec_main.c |   71 +++++++++--------------------
>  include/linux/ethtool.h                   |    5 ++
>  net/core/ethtool.c                        |   24 ++++++++++
>  4 files changed, 50 insertions(+), 51 deletions(-)
> 
> --
> 1.7.4.4

Acked-by: Fugang Duan <fugang.duan@....com>