netdev - Re: [PATCH v3 net-next] tcp: replace cnt & rtt with struct in pkts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 May 2016 23:49:55 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	brakmo@...com
Cc:	netdev@...r.kernel.org, kernel-team@...com, ncardwell@...gle.com,
	eric.dumazet@...il.com, ycheng@...gle.com
Subject: Re: [PATCH v3 net-next] tcp: replace cnt & rtt with struct in
 pkts_acked()

From: David Miller <davem@...emloft.net>
Date: Tue, 10 May 2016 23:47:58 -0400 (EDT)

> From: Lawrence Brakmo <brakmo@...com>
> Date: Tue, 10 May 2016 13:11:09 -0700
> 
>> Replace 2 arguments (cnt and rtt) in the congestion control modules'
>> pkts_acked() function with a struct. This will allow adding more
>> information without having to modify existing congestion control
>> modules (tcp_nv in particular needs bytes in flight when packet
>> was sent).
>> 
>> As proposed by Neal Cardwell in his comments to the tcp_nv patch.
>> 
>> Signed-off-by: Lawrence Brakmo <brakmo@...com>
>> Acked-by: Yuchung Cheng <ycheng@...gle.com>
> 
> Applied, thanks.

Actually I had to revert, this breaks the build:

net/ipv4/tcp_illinois.c: In function ‘tcp_illinois_acked’:
net/ipv4/tcp_illinois.c:97:18: error: assignment of member ‘rtt_us’ in read-only object
   sample->rtt_us = RTT_MAX;

You can't mark this argument const.