netdev - Re: [PATCHv2] net: suppress warnings on dev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 May 2016 19:59:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nhorman@...driver.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com,
	alexander.duyck@...il.com
Subject: Re: [PATCHv2] net: suppress warnings on dev_alloc_skb

From: Neil Horman <nhorman@...driver.com>
Date: Thu, 19 May 2016 11:30:54 -0400

> Noticed an allocation failure in a network driver the other day on a 32 bit
> system:
 ...
> Thought that perhaps the big splat in the logs wasn't really necessecary, as
> all call sites for dev_alloc_skb:
> 
> a) check the return code for the function
> 
> and
> 
> b) either print their own error message or have a recovery path that makes the
> warning moot.
> 
> Fix it by modifying dev_alloc_pages to pass __GFP_NOWARN as a gfp flag to
> suppress the warning
> 
> applies to the net tree
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>

Applied, thanks Neil.