netdev - Re: [PATCH iproute2 v3 5/5] ip: add MACsec support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 May 2016 16:21:42 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Sabrina Dubroca <sd@...asysnail.net>
Cc:	netdev@...r.kernel.org, Phil Sutter <phil@....cc>
Subject: Re: [PATCH iproute2 v3 5/5] ip: add MACsec support

On Wed, 18 May 2016 17:35:13 +0200
Sabrina Dubroca <sd@...asysnail.net> wrote:

> +
> +static void print_rx_sc(const char *prefix, __u64 sci, __u8 active, struct rtattr *rxsc_stats, struct rtattr *sa)
> +{

Overall, this looks fine, but could you break some of the really long lines.
In general, I like iproute2 to follow kernel style, and in general stick to
the 80 column recommendation where it makes sense.  Spliting strings or 
stuff in loops may not make sense. There are several places in this code
longer than 100 chars.