netdev - Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 31 May 2016 14:33:01 -0400
From:	"George G. Davis" <george_davis@...tor.com>
To:	Russell King - ARM Linux <linux@...linux.org.uk>
CC:	Fabio Estevam <festevam@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Fugang Duan <fugang.duan@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <kernel@...gutronix.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>
Subject: Re: [PATCH] net: fec: dt: convert phy-reset-gpios to use GPIOD API

Hello Russell,

On Tue, May 31, 2016 at 07:26:42PM +0100, Russell King - ARM Linux wrote:
> On Tue, May 31, 2016 at 02:24:50PM -0400, George G. Davis wrote:
> > Hello Fabio,
> > 
> > On Tue, May 31, 2016 at 02:26:54PM -0300, Fabio Estevam wrote:
> > > On Tue, May 31, 2016 at 2:17 PM, George G. Davis
> > > <george_davis@...tor.com> wrote:
> > > > Convert the i.MX FEC driver and DT files to use the GPIOD API
> > > > which automatically handles GPIO polarity.
> > > >
> > > > Signed-off-by: George G. Davis <george_davis@...tor.com>
> > > 
> > > In order to avoid breaking old dtb's a property called
> > > 'phy-reset-active-high' has been introduced.
> > > 
> > > Check: 962d8cdc3133435a ("net: fec: Rename "phy-reset-active-low"
> > > property") and 64f10f6ebf5a6d3ae ("net: fec: Add
> > > "phy-reset-active-low" property to DT").
> > 
> > The GPIOD API handles GPIO active assertion levels as defined by the 
> > DT binding. So the phy-reset-active-high and/or phy-reset-active-low
> > property is not needed when using the GPIOD API - just define
> > GPIO_ACTIVE_LOW or GPIO_ACTIVE_HIGH as required for the board and the
> > GPIOD API will handle active assert/deassert level as needed.
> 
> You must retain compatibility with _existing_ DT files.  Hence,
> while you can convert to using the gpiod API, you still need to
> be compatible with the old way of specifying this - iow, you must
> support the old properties in the code.

Sigh, thanks for the ClueBat. Got it. I'll rework the patch to retain
compatibility with existing DT files.

-- 
Regards,
George