netdev - Re: [PATCH] rxrpc: Use pr_<level> and pr_fmt, reduce object size a few KB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 03 Jun 2016 19:41:48 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	dhowells@...hat.com, rjui@...adcom.com, sbranden@...adcom.com,
	jonmason@...adcom.com, linux-afs@...ts.infradead.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH] rxrpc: Use pr_<level> and pr_fmt, reduce object size a
 few KB

From: Joe Perches <joe@...ches.com>
Date: Thu,  2 Jun 2016 12:08:52 -0700

> Use the more common kernel logging style and reduce object size.
> 
> The logging message prefix changes from a mixture of
> "RxRPC:" and "RXRPC:" to "af_rxrpc: ".
> 
> $ size net/rxrpc/built-in.o*
>    text	   data	    bss	    dec	    hex	filename
>   64172	   1972	   8304	  74448	  122d0	net/rxrpc/built-in.o.new
>   67512	   1972	   8304	  77788	  12fdc	net/rxrpc/built-in.o.old
> 
> Miscellanea:
> 
> o Consolidate the ASSERT macros to use a single pr_err call with
>   decimal and hexadecimal output and a stringified #OP argument
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Looks good to me, applied, thanks Joe.