netdev - RE: [PATCH v2 7/7] phy: Add Northstar2 PCI Phy support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Jun 2016 16:53:51 +0530
From:	Pramod Kumar <pramod.kumar@...adcom.com>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Kishon Vijay Abraham I <kishon@...com>,
	"David S. Miller" <davem@...emloft.net>,
	devicetree@...r.kernel.org, Jon Mason <jonmason@...adcom.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	bcm-kernel-feedback-list@...adcom.com,
	linux-arm-kernel@...ts.infradead.org
Subject: RE: [PATCH v2 7/7] phy: Add Northstar2 PCI Phy support

Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn [mailto:andrew@...n.ch]
> Sent: 01 June 2016 18:42
> To: Pramod Kumar
> Cc: Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala;
Catalin
> Marinas; Will Deacon; Kishon Vijay Abraham I; David S. Miller;
> devicetree@...r.kernel.org; Jon Mason; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; bcm-kernel-feedback-list@...adcom.com;
linux-arm-
> kernel@...ts.infradead.org
> Subject: Re: [PATCH v2 7/7] phy: Add Northstar2 PCI Phy support
>
> > +static int ns2_pci_phy_probe(struct mdio_device *mdiodev) {
> > +	struct device *dev = &mdiodev->dev;
> > +	struct phy_provider *provider;
> > +	struct ns2_pci_phy *p;
> > +	struct phy *phy;
> > +
> > +	phy = devm_phy_create(dev, dev->of_node, &ns2_pci_phy_ops);
> > +	if (IS_ERR_OR_NULL(phy)) {
> > +		dev_err(dev, "failed to create Phy\n");
> > +		return PTR_ERR(phy);
> > +	}
>
> https://www.mail-archive.com/linux-omap@vger.kernel.org/msg78030.html
>

I've explored inside this API and see it never returning NULL. I'll
replace IS_ERR_OR_NULL to IS_ERR.
Thanks for pointing this out.

> 	Andrew

Regards,
Pramod