Date:	Mon, 6 Jun 2016 09:44:36 +0000
From:	Gabriele Paoloni <gabriele.paoloni@...wei.com>
To:	"Izumi, Taku" <izumi.taku@...fujitsu.com>,
	"liudongdong (C)" <liudongdong3@...wei.com>
CC:	Linuxarm <linuxarm@...wei.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [bug discuss] fjes driver call trace warning, "PNP0C02" used in
 fjes	seems like a bug,

Hi Taku Izumi

> -----Original Message-----
> From: Izumi, Taku [mailto:izumi.taku@...fujitsu.com]
> Sent: 06 June 2016 10:34
> To: Gabriele Paoloni; liudongdong (C)
> Cc: Linuxarm; netdev@...r.kernel.org
> Subject: RE: [bug discuss] fjes driver call trace warning, "PNP0C02"
> used in fjes seems like a bug,
> 
> Dear Liu,
> 
> > -----Original Message-----
> > From: Gabriele Paoloni [mailto:gabriele.paoloni@...wei.com]
> > Sent: Friday, June 03, 2016 6:59 PM
> > To: liudongdong (C); Izumi, Taku/泉 拓
> > Cc: Linuxarm; netdev@...r.kernel.org
> > Subject: RE: [bug discuss] fjes driver call trace warning, "PNP0C02"
> used in fjes seems like a bug,
> >
> > Hi Dongdong
> >
> > Thanks for flagging this
> >
> > +to: Taku Izumi <izumi.taku@...fujitsu.com>
> >
> > Gab
> >
> > > -----Original Message-----
> > > From: linuxarm-bounces@...wei.com [mailto:linuxarm-
> bounces@...wei.com]
> > > On Behalf Of Dongdong Liu
> > > Sent: 03 June 2016 10:38
> > > To: netdev@...r.kernel.org
> > > Cc: Linuxarm
> > > Subject: [bug discuss] fjes driver call trace warning, "PNP0C02"
> used
> > > in fjes seems like a bug,
> > >
> > > Hi all:
> > >
> > > The bug is recorded in https://bugs.linaro.org/show_bug.cgi?id=2292.
> > >
> > > "PNP0C02" attached two modules drivers/pnp/system.c and
> > > drivers/net/fjes/fjes_main.c .
> > > "fjes" driver lead to the call trace.
> > >
> > > system.c:
> > > static const struct pnp_device_id pnp_dev_table[] = {
> > >          /* General ID for reserving resources */
> > >          {"PNP0c02", 0},
> > >          /* memory controller */
> > >          {"PNP0c01", 0},
> > >          {"", 0}
> > > };
> > >
> > > jes_main.c:
> > > static const struct acpi_device_id fjes_acpi_ids[] = {
> > >          {"PNP0C02", 0},
> > >          {"", 0},
> > > };
> > >
> > > Both of the modules use id "PNP0C02" (case insensitive),
> > >
> > > I used "PNP0C02" to mark motherboard reserved resource as below in
> > > UEFI.
> > > Device (RES1)
> > > {
> > > 	Name (_HID, "HISI0081") // HiSi PCIe RC config baseaddress
> > > 	Name (_CID, "PNP0C02") // Motherboard reserved resource
> > > 		Name (_CRS, ResourceTemplate (){
> > > 			Memory32Fixed (ReadWrite, 0xb0080000 , 0x10000)
> > > 		})
> > > }
> > >
> > > I think that "PNP0C02" should be used to mark any motherboard
> reserved
> > > resource and not a specific network driver.
> > > It seems like a bug in the "fjes" driver.
> 
>   Extended Socket network device is a shared memory based high-speed
>   network interface between Extended Partitions of PRIMEQUEST 2000 E2
>   series. To check if firmware supports Extended Socket network device,
>   we take use of  "PCP0C02" device and special strings in DSDT.
> 
>   "fjes" is not only "platform device driver (mainly act as network
>    driver" but also "acpi driver" . If "PCP0C02" found and it is for
>    Extended Socket network device, platform_device will be created.

>From my understanding PNP0C02 is not a valid ACPI device HID but it is
to be used only to reserve motherboard resources.

Can you please explain your identifier choice?

Thanks

Gab

> 
>   Sincerely,
>   Taku Izumi
> 
> > >
> > > Thanks
> > >
> > > Dongdong
> > >
> > >
> > >
> > >
> > > _______________________________________________
> > > linuxarm mailing list
> > > linuxarm@...wei.com
> > > http://rnd-openeuler.huawei.com/mailman/listinfo/linuxarm

Powered by blists - more mailing lists