netdev - Re: [PATCH v3] r8152: Add support for setting pass through MAC address on RTL8153-AD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jun 2016 07:50:21 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Mario_Limonciello@...l.com
Cc:	hayeswang@...ltek.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	pali.rohar@...il.com, anthony.wong@...onical.com
Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC
 address on RTL8153-AD

On Mon, Jun 06, 2016 at 02:43:37PM +0000, Mario_Limonciello@...l.com wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@...uxfoundation.org]
> > Sent: Monday, June 6, 2016 9:40 AM
> > To: Limonciello, Mario <Mario_Limonciello@...l.com>
> > Cc: hayeswang@...ltek.com; LKML <linux-kernel@...r.kernel.org>; Netdev
> > <netdev@...r.kernel.org>; Linux USB <linux-usb@...r.kernel.org>;
> > pali.rohar@...il.com; anthony.wong@...onical.com
> > Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC
> > address on RTL8153-AD
> > 
> > On Mon, Jun 06, 2016 at 09:15:20AM -0500, Mario Limonciello wrote:
> > > Since this is a Realtek feature, I feel this shouldn't be moved into a platform
> > > MAC address lookup.  The code should only be run when the correct
> > Realtek device
> > > is plugged in.
> > >
> > > Changes from v2:
> > >  * Only apply to RTL8153-AD w/ eFuse pass through mac address pass thru
> > >    bit set.
> > >  * Drop matching DMI information on Dell.  Although this is implemented
> > on
> > >    Dell, this is a Realtek feature that may may be implemented on other
> > >    OEMs as well.
> > >  * Test that pass through MAC address is valid, fall back to HW address if
> > >    invalid.
> > >  * Don't track status of which device has MAC pass through activated.
> > >  - Expected experience is that if two docks (RTL8153-AD's w/ mac pass thru
> > >    bit set) were plugged in both should have MAC pass through activated.
> > 
> > cover letters for single-patch submissions is overkill and confusing,
> > please don't.
> 
> I was trying to convey differences between versions of this patch, I'll avoid
> that in the future and let the audience find them themselves.

No, put them in the patch itself, under the --- line, like is documented
to do so.  Don't make people "find them themselves", if you do that,
your patch will just be ignored.

greg k-h