| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 Jun 2016 15:19:16 +0000 From: "Valo, Kalle" <kvalo@....qualcomm.com> To: David Binderman <linuxdev.baldrick@...il.com> CC: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "dcb314@...mail.com" <dcb314@...mail.com>, "ath6kl@...ts.infradead.org" <ath6kl@...ts.infradead.org> Subject: Re: linux-4.7-rc2/drivers/net/wireless/ath/ath6kl/wmi.c:2547]: (style) Redundant condition David Binderman <linuxdev.baldrick@...il.com> writes: > Hello there, > > linux-4.7-rc2/drivers/net/wireless/ath/ath6kl/wmi.c:2547]: (style) > Redundant condition: If 'EXPR <= 7', the comparison 'EXPR < 8' is > always true. > > Source code is > > if (!((params->user_pri < 8) && > (params->user_pri <= 0x7) && > > This might be a possible cut'n'paste error. This should be recently fixed: https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=93b4a09f0f3068e3190548393f39262e5295960e > Also in the same file > > [drivers/net/wireless/ath/ath6kl/wmi.c:1220]: (style) Variable 'rate' > is assigned a value that is never used. > [drivers/net/wireless/ath/ath6kl/wmi.c:1484]: (style) Variable > 'new_threshold' is assigned a value that is never used. > [drivers/net/wireless/ath/ath6kl/wmi.c:3521]: (style) Variable 'ret' > is assigned a value that is never used. I guess these are still valid. -- Kalle Valo
Powered by blists - more mailing lists