netdev - Re: [PATCH -next] cbq: remove only caller of qdisc->drop()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 07 Jun 2016 17:11:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH -next] cbq: remove only caller of qdisc->drop()

From: Florian Westphal <fw@...len.de>
Date: Mon,  6 Jun 2016 23:20:27 +0200

> since initial revision of cbq in 2004 iproute2 never implemented
> support for TCA_CBQ_OVL_STRATEGY, which is what needs to be set to
> activate the class->drop() call (TC_CBQ_OVL_DROP strategy must be
> set by userspace).
> 
> So lets remove this.  We can even do this in a backwards compatible
> way by switching ovl_drop to perform a dequeue+drop on the leaf.
> 
> A followup commit can then remove all .drop qdisc methods since this
> was the only caller.
> 
> Signed-off-by: Florian Westphal <fw@...len.de>

I don't see anything, anywhere, using TCA_CBQ_OVL_STRATEGY nor the
various strategy type values.

iproute2 seems to notice the attribute in dumps, but doesn't do
anything with it other than verify that it's size meets some minimum.

It seems really safe to kill this thing off, flag an error if someone
tries to set the attribute, and therefore kill off all of the non-default
cbq_ovl_*() functions.

>   I think it would be safe to just ignore TCA_CBQ_POLICE and change the
>   qdiscs to drop right away.
> 
>   Does anyone have a reason to leave this in the tree?  Thanks!

The TCA_CBQ_POLICE situation looks similar to the TCA_CBQ_OVL_STRATEGY
one to me.

Thanks.