netdev - Re: [PATCH net] l2tp: fix configuration passed to setup_udp_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 8 Jun 2016 12:35:38 +0200
From:	Guillaume Nault <g.nault@...halink.fr>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, tom@...bertland.com, jchapman@...alix.com
Subject: Re: [PATCH net] l2tp: fix configuration passed to
 setup_udp_tunnel_sock()

On Tue, Jun 07, 2016 at 04:20:17PM -0700, David Miller wrote:
> From: Guillaume Nault <g.nault@...halink.fr>
> Date: Mon, 6 Jun 2016 13:48:02 +0200
> 
> > @@ -1581,7 +1581,7 @@ int l2tp_tunnel_create(struct net *net, int fd, int version, u32 tunnel_id, u32
> >  	/* Mark socket as an encapsulation socket. See net/ipv4/udp.c */
> >  	tunnel->encap = encap;
> >  	if (encap == L2TP_ENCAPTYPE_UDP) {
> > -		struct udp_tunnel_sock_cfg udp_cfg;
> > +		struct udp_tunnel_sock_cfg udp_cfg = { NULL };
> 
> This assumes that the first member of udp_tunnel_sock_cfg is, and will always
> be, a pointer.
> 
> You could use a named initializer to make this better, but the cleanest way to
> deal with this is to use an empty initializer "{ }", or just plain memset()
> the thing to zero.
> 
Indeed. I'll repost using "{ }" then.