netdev - Re: [PATCH net-next 1/5] net: dsa: b53: Add support for Broadcom RoboSwitch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Jun 2016 20:57:20 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev@...r.kernel.org, vivien.didelot@...oirfairelinux.com,
	davem@...emloft.net, jon.mason@...adcom.com,
	hemal.shah@...adcom.com, bandaru.viswanath@...adcom.com,
	michael.chan@...adcom.com, jogo@...nwrt.org, cphealy@...il.com,
	ardeleanalex@...il.com, jiri@...lanox.com, idosch@...lanox.com
Subject: Re: [PATCH net-next 1/5] net: dsa: b53: Add support for Broadcom
 RoboSwitch

> >> +static inline int b53_switch_get_reset_gpio(struct b53_device *dev)
> >> +{
> >> +	enum bcm47xx_board board = bcm47xx_board_get();
> >> +
> >> +	switch (board) {
> >> +	case BCM47XX_BOARD_LINKSYS_WRT300NV11:
> >> +	case BCM47XX_BOARD_LINKSYS_WRT310NV1:
> >> +		return 8;
> > 
> > Rather than hard coding it, could we get it from device tree?
> 
> Difficult for now, this is for in-tree MIPS-based platforms under
> arch/mips/bcm47xx, which are using SSB/platform data.

Ah, O.K.

But it would not harm to also support getting the GPIO from device
tree, if device tree is available. But maybe that should wait until
such a user comes along.

     Andrew