netdev - Re: [PATCH] stmmac: fix parameter to dwmac4_set_umac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 09 Jun 2016 23:39:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ben.dooks@...ethink.co.uk
Cc:	linux-kernel@...ts.codethink.co.uk, peppe.cavallaro@...com,
	alexandre.torgue@...com, netdev@...r.kernel.org
Subject: Re: [PATCH] stmmac: fix parameter to dwmac4_set_umac_addr()

From: Ben Dooks <ben.dooks@...ethink.co.uk>
Date: Wed,  8 Jun 2016 19:21:17 +0100

> The dwmac4_set_umac_addr() takes a struct mac_device_info as
> the first parameter, but is being passed a ioaddr instead from
> dwmac4_set_filter(). Fix the warning/bug by changing the first
> parameter.
> 
> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:159:46: warning: incorrect type in argument 1 (different address spaces)
> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:159:46:    expected struct mac_device_info *hw
> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c:159:46:    got void [noderef] <asn:2>*ioaddr
> 
> Note, only compile tested this as do not have any
> hardware with it in.
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>

Applied.