netdev - Re: [PATCH net] ipv6: fix endianness error in icmpv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Jun 2016 12:38:30 +0900
From:	Lorenzo Colitti <lorenzo@...gle.com>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] ipv6: fix endianness error in icmpv6_err

On Sun, Jun 12, 2016 at 3:32 AM, Hannes Frederic Sowa
<hannes@...essinduktion.org> wrote:
> IPv6 ping socket error handler doesn't correctly convert the new 32 bit
> mtu to host endianness before using.
> ...
>         if (!(type & ICMPV6_INFOMSG_MASK))
>                 if (icmp6->icmp6_type == ICMPV6_ECHO_REQUEST)
> -                       ping_err(skb, offset, info);
> +                       ping_err(skb, offset, ntohl(info));
>  }

Acked-by: Lorenzo Colitti <lorenzo@...gle.com>