netdev - Re: [net-next PATCH v2 03/17] net: Merge VXLAN and GENEVE push notifiers into a single notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Jun 2016 16:51:04 -0700
From:	Jesse Gross <jesse@...nel.org>
To:	Alexander Duyck <aduyck@...antis.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	intel-wired-lan@...ts.osuosl.org,
	Hannes Frederic Sowa <hannes@...hat.com>,
	eugenia@...lanox.com, Jiri Benc <jbenc@...hat.com>,
	Alexander Duyck <alexander.duyck@...il.com>,
	saeedm@...lanox.com, Ariel Elior <ariel.elior@...gic.com>,
	Tom Herbert <tom@...bertland.com>, michael.chan@...adcom.com,
	Dept-GELinuxNICDev@...gic.com, David Miller <davem@...emloft.net>
Subject: Re: [net-next PATCH v2 03/17] net: Merge VXLAN and GENEVE push
 notifiers into a single notifier

On Wed, Jun 15, 2016 at 3:07 PM, Alexander Duyck <aduyck@...antis.com> wrote:
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index d101e4d904ba..7f45e96967ce 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1050,6 +1052,19 @@ struct tc_to_netdev {
>   *     address family that vxlan is not listening to anymore. The operation
>   *     is protected by the vxlan_net->sock_lock.
>   *
> + * void (*ndo_udp_tunnel_add)(struct net_device *dev,
> + *                           struct udp_tunnel_info *ti);
> + *     Called by UDP tunnel to notify a driver about the UDP port and socket
> + *     address family that a UDP tunnel is listnening to. It is called only
> + *     when a new port starts listening. The operation is protected by the
> + *     tunnel socket lock.
> + *
> + * void (*ndo_udp_tunnel_del)(struct net_device *dev,
> + *                           struct udp_tunnel_info *ti);
> + *     Called by UDP tunnel to notify the driver about a UDP port and socket
> + *     address family that the UDP tunnel is not listening to anymore. The
> + *     operation is protected by the tunnel socket lock.

I think these comments are out of date - these operations are now
protected by RTNL instead of individual tunnel locks. Having
individual locks doesn't really work because drivers likely share
information for different tunnel types in the same data structures.