netdev - Re: [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jun 2016 16:25:14 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Yisen Zhuang <Yisen.Zhuang@...wei.com>, davem@...emloft.net,
	salil.mehta@...wei.com, yankejian@...wei.com
Cc:	liguozhu@...wei.com, huangdaode@...ilicon.com, arnd@...db.de,
	andriy.shevchenko@...ux.intel.com, andrew@...n.ch,
	geliangtang@....com, ivecera@...hat.com, fengguang.wu@...el.com,
	charles.chenxin@...wei.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linuxarm@...wei.com
Subject: Re: [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead
 to port unavailable

Hello.

On 6/21/2016 6:56 AM, Yisen Zhuang wrote:

> From: Jun He <hjat2005@...wei.com>
>
> When hns_nic_poll_rx_skb alloc skb fail, it will break receive cycle and
> read new fbd_num to start new receive cycle. It recomputes cycle num is
> fbd_num minus clean_count, actually this cycle num is too big because
> it drop out receive cycle. It brings about the port unavailable.
>
> So we will goto out when alloc skb fail to fix this bug.
>
> Signed-off-by: Jun He <hjat2005@...wei.com>
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>
> Signed-off-by: Yisen Zhuang <Yisen.Zhuang@...wei.com>
> ---
>  drivers/net/ethernet/hisilicon/hns/hns_enet.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> index f49246d..c0ce37b 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> @@ -768,10 +768,10 @@ recv:
>  			clean_count = 0;
>  		}
>
> -		/* poll one pkg*/
> +		/* poll one pkt*/

    How about adding a space before */?

[...]

MBR, Sergei