netdev - Re: [PATCH -next 2/4] cgroup: bpf: Add BPF_MAP_TYPE_CGROUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Jun 2016 10:33:01 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Martin KaFai Lau <kafai@...com>
Cc:	kbuild-all@...org, cgroups@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Alexei Starovoitov <ast@...com>,
	Daniel Borkmann <daniel@...earbox.net>,
	Tejun Heo <tj@...nel.org>, kernel-team@...com
Subject: Re: [PATCH -next 2/4] cgroup: bpf: Add BPF_MAP_TYPE_CGROUP_ARRAY

Hi,

[auto build test ERROR on next-20160621]

url:    https://github.com/0day-ci/linux/commits/Martin-KaFai-Lau/cgroup-bpf-cgroup2-membership-test-on-skb/20160622-082800
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All error/warnings (new ones prefixed by >>):

   kernel/bpf/arraymap.c: In function 'cgroup_fd_array_get_ptr':
>> kernel/bpf/arraymap.c:547:2: error: implicit declaration of function 'cgroup_get_from_fd' [-Werror=implicit-function-declaration]
     return cgroup_get_from_fd(fd);
     ^
>> kernel/bpf/arraymap.c:547:2: warning: return makes pointer from integer without a cast
   kernel/bpf/arraymap.c: In function 'cgroup_fd_array_put_ptr':
>> kernel/bpf/arraymap.c:553:2: error: implicit declaration of function 'cgroup_put' [-Werror=implicit-function-declaration]
     cgroup_put(ptr);
     ^
   cc1: some warnings being treated as errors

vim +/cgroup_get_from_fd +547 kernel/bpf/arraymap.c

   541	late_initcall(register_perf_event_array_map);
   542	
   543	static void *cgroup_fd_array_get_ptr(struct bpf_map *map,
   544					     struct file *map_file /* not used */,
   545					     int fd)
   546	{
 > 547		return cgroup_get_from_fd(fd);
   548	}
   549	
   550	static void cgroup_fd_array_put_ptr(void *ptr)
   551	{
   552		/* cgroup_put free cgrp after a rcu grace period */
 > 553		cgroup_put(ptr);
   554	}
   555	
   556	static void cgroup_fd_array_free(struct bpf_map *map)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (11770 bytes)