netdev - Re: [PATCH net] team: Fix possible deadlock during team enslave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 22 Jun 2016 16:32:55 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	idosch@...lanox.com
Cc:	netdev@...r.kernel.org, jiri@...lanox.com, eladr@...lanox.com,
	yotamg@...lanox.com, nogahf@...lanox.com, ogerlitz@...lanox.com,
	lucien.xin@...il.com
Subject: Re: [PATCH net] team: Fix possible deadlock during team enslave

From: Ido Schimmel <idosch@...lanox.com>
Date: Mon, 20 Jun 2016 11:53:20 +0300

> Both dev_uc_sync_multiple() and dev_mc_sync_multiple() require the
> source device to be locked by netif_addr_lock_bh(), but this is missing
> in team's enslave function, so add it.
> 
> This fixes the following lockdep warning:
> 
> Possible interrupt unsafe locking scenario:
> 
>         CPU0                    CPU1
>         ----                    ----
>    lock(_xmit_ETHER/1);
>                                 local_irq_disable();
>                                 lock(&(&mc->mca_lock)->rlock);
>                                 lock(&team_netdev_addr_lock_key);
>    <Interrupt>
>      lock(&(&mc->mca_lock)->rlock);
> 
>   *** DEADLOCK ***
> 
> Fixes: cb41c997d444 ("team: team should sync the port's uc/mc addrs when add a port")
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>

Applied.