netdev - Re: [PATCH net-next] net: dsa: b53: Fix statistics readings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 23 Jun 2016 15:20:27 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org, andrew@...n.ch,
	vivien.didelot@...oirfairelinux.com, jogo@...nwrt.org
Subject: Re: [PATCH net-next] net: dsa: b53: Fix statistics readings

From: Florian Fainelli <f.fainelli@...il.com>
Date: Mon, 20 Jun 2016 18:26:53 -0700

> Due to a typo we would always be using the MIB counter width of the
> first element of the counter array instead of the current element, and
> we would always be accessing the register statistics with a 64-bits
> read, while some could be 32-bits. This got unnoticed in testing with
> MDIO and SRAB which tolerate doing this, but testing with the SPI bus
> revealed bogus values being returned. Fix this by using the proper
> iterator here.
> 
> Fixes: 967dd82ffc52 ("net: dsa: b53: Add support for Broadcom RoboSwitch")
> Reported-by: Jonas Gorski <jogo@...nwrt.org>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied.