netdev - Re: [PATCH v2] net/mlx5: use mlx5_buf_alloc_node instead of mlx5_buf_alloc in mlx5_wq_ll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 23 Jun 2016 10:34:11 +0300
From:	Saeed Mahameed <saeedm@....mellanox.co.il>
To:	Wang Sheng-Hui <shhuiw@...mail.com>
Cc:	Saeed Mahameed <saeedm@...lanox.com>,
	Amir Vadai <amirv@...lanox.com>,
	Matan Barak <matanb@...lanox.com>,
	Leon Romanovsky <leonro@...lanox.com>,
	Linux Netdev List <netdev@...r.kernel.org>,
	linux-rdma@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] net/mlx5: use mlx5_buf_alloc_node instead of
 mlx5_buf_alloc in mlx5_wq_ll_create

On Thu, Jun 23, 2016 at 4:04 AM, Wang Sheng-Hui <shhuiw@...mail.com> wrote:
> Fixes: 311c7c71c9bb ("net/mlx5e: Allocate DMA coherent memory on
> reader NUMA node")
>

Hi Wang,

I am sorry for the nitpicking, but the commit message needs to be improved.

I prefer putting the "Fixes" line only after the bug description
(commit message) just before the Signed-of-by line. you can find some
examples in the commit log history.

>
> Change since V1:
>         * Add Fixes line in commit log
>

This should come only after the "---" below so it won't appear in the
commit log.

http://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb

> Signed-off-by: Wang Sheng-Hui <shhuiw@...mail.com>
> ---

["Changes since" goes here]

>  drivers/net/ethernet/mellanox/mlx5/core/wq.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
>

Thanks,
Saeed