lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Jun 2016 15:55:27 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Marc Kleine-Budde <mkl@...gutronix.de>, netdev@...r.kernel.org Cc: davem@...emloft.net, linux-can@...r.kernel.org, kernel@...gutronix.de, Oliver Hartkopp <socketcan@...tkopp.net>, stable@...r.kernel.org Subject: Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage Hello. On 6/23/2016 12:22 PM, Marc Kleine-Budde wrote: > From: Oliver Hartkopp <socketcan@...tkopp.net> > > For 'real' hardware CAN devices the netlink interface is used to set CAN > specific communication parameters. Real CAN hardware can not be created nor > removed with the ip tool ... > > This patch adds a private dellink function for the CAN device driver interface > that does just nothing. > > It's a follow up to commit 993e6f2fd ("can: fix oops caused by wrong rtnl > newlink usage") but for dellink. > > Reported-by: ajneu <ajneu1@...il.com> > Signed-off-by: Oliver Hartkopp <socketcan@...tkopp.net> > Cc: <stable@...r.kernel.org> > Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de> > --- > drivers/net/can/dev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c > index 348dd5001fa4..ad535a854e5c 100644 > --- a/drivers/net/can/dev.c > +++ b/drivers/net/can/dev.c > @@ -1011,6 +1011,11 @@ static int can_newlink(struct net *src_net, struct net_device *dev, > return -EOPNOTSUPP; > } > > +static void can_dellink(struct net_device *dev, struct list_head *head) > +{ > + return; Why? > +} > + > static struct rtnl_link_ops can_link_ops __read_mostly = { > .kind = "can", > .maxtype = IFLA_CAN_MAX, [...] MBR, Sergei
Powered by blists - more mailing lists