netdev - RE: [iproute PATCH v3 6/6] misc/ifstat: simplify unsigned value comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Jun 2016 09:20:32 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Phil Sutter' <phil@....cc>,
	Stephen Hemminger <shemming@...cade.com>
CC:	Daniel Borkmann <daniel@...earbox.net>,
	David Ahern <dsa@...ulusnetworks.com>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Julien Floret <julien.floret@...nd.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [iproute PATCH v3 6/6] misc/ifstat: simplify unsigned value
 comparison

From: Phil Sutter
> Sent: 23 June 2016 18:34
> 
> By directly comparing the value of both unsigned variables, casting to
> signed becomes unnecessary.
> 
> This also fixes for compiling with older versions of gcc (at least
> <=3.4.6) which emit the following warning:
> 
> | ifstat.c: In function `update_db':
> | ifstat.c:542: warning: comparison is always false due to limited range of data type
> 
> Signed-off-by: Phil Sutter <phil@....cc>
> ---
>  misc/ifstat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/misc/ifstat.c b/misc/ifstat.c
> index abbb4e732fcef..9a44da487599e 100644
> --- a/misc/ifstat.c
> +++ b/misc/ifstat.c
> @@ -539,7 +539,7 @@ static void update_db(int interval)
>  				int i;
> 
>  				for (i = 0; i < MAXS; i++) {
> -					if ((long)(h1->ival[i] - n->ival[i]) < 0) {
> +					if (h1->ival[i] < n->ival[i]) {
>  						memset(n->ival, 0, sizeof(n->ival));
>  						break;

That isn't the same check.
The original code is using modulo arithmetic.

	David