netdev - [PATCH net 0/5] batman-adv: Fixes for Linux 4.7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 26 Jun 2016 11:15:12 +0200
From:	Sven Eckelmann <sven@...fation.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org,
	Antonio Quartulli <a@...table.cc>
Subject: [PATCH net 0/5] batman-adv: Fixes for Linux 4.7

Hi David,

Antonio currently seems to be occupied. This is currently rather unfortunate 
because there are patches waiting in the batman-adv development repository 
maint(enance) branch [1] since up to 6 weeks. I am now getting asked when 
these patches will hit the distribution kernels and therefore decided to 
submit these patches directly to netdev.

The patch from Simon works around the problem that warnings could be triggered 
in the translation table code via packets using a VLAN not configured on the 
target host. This warning was replaced with a rate limited info message.

Ben Hutchings found an superfluous batadv_softif_vlan_put in the error 
handling code of the translation table while he backported the "batman-adv: 
Fix reference counting of vlan object for tt_local_entry" patch to the stable 
kernels. He noticed correctly that this batadv_softif_vlan_put should also 
have been removed by the said patch.

The most requested fix at the moment is related to a double free in the 
translation table code. It is a race condition which mostly happens on systems 
with multiple cores and multiple network interface attached to batman-adv. Two 
Freifunk communities which were haunted by weird crashes (with backtraces 
reporting problems in other parts of the kernel) were kind enough to test this 
patch. They reported that there systems are now running stable after applying 
this patch.

An invalid memory access was detected in the batadv_icmp_packet_rr handling 
code when receiving a skbuff with fragments. The last patch is fixing a memory 
leak when the interface is removed via .dellink. The code to fix it was copied 
from the code handling the legacy sysfs interface to remove netdevices from a 
batman-adv netdevice.

There are still 28 patches in the development tree for v4.8 but I will leave 
them to Antonio because these are cleanups and features and therefore for net-
next.

Ben Hutchings (1):
      batman-adv: Fix double-put of vlan object

Simon Wunderlich (1):
      batman-adv: replace WARN with rate limited output on non-existing VLAN

Sven Eckelmann (3):
      batman-adv: Fix use-after-free/double-free of tt_req_node
      batman-adv: Fix ICMP RR ethernet access after skb_linearize
      batman-adv: Clean up untagged vlan when destroying via rtnl-link

net/batman-adv/routing.c           |  1 +
net/batman-adv/soft-interface.c    |  9 +++++++
net/batman-adv/translation-table.c | 50 +++++++++++++++++++++++++++++++-------
net/batman-adv/types.h             |  2 ++
4 files changed, 53 insertions(+), 9 deletions(-)

Kind regards,
	Sven

[1] https://git.open-mesh.org/batman-adv.git/shortlog/refs/heads/maint

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)