netdev - Re: [PATCH] net: stmmac: Fix null-function call in ISR on stmmac1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jun 2016 07:50:30 +0200
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Matt Corallo <linux@...ematt.me>,
	<linux-amlogic@...ts.infradead.org>
CC:	Alexandre Torgue <alexandre.torgue@...com>,
	<netdev@...r.kernel.org>, <martin.blumenstingl@...glemail.com>
Subject: Re: [PATCH] net: stmmac: Fix null-function call in ISR on stmmac1000

Thanks Matt for the fix

On 6/25/2016 9:35 PM, Matt Corallo wrote:
> At least on Meson GXBB, the CORE_IRQ_MTL_RX_OVERFLOW interrupt is thrown
> with the stmmac1000 driver, which does not support set_rx_tail_ptr. With
> this patch and the clock fixes, 1G ethernet works on ODROID-C2.
>
> Signed-off-by: Matt Corallo <git@...ematt.me>

Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index a473c18..e407126 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -2804,7 +2804,7 @@ static irqreturn_t stmmac_interrupt(int irq, void
> *dev_id)
>  				priv->tx_path_in_lpi_mode = true;
>  			if (status & CORE_IRQ_TX_PATH_EXIT_LPI_MODE)
>  				priv->tx_path_in_lpi_mode = false;
> -			if (status & CORE_IRQ_MTL_RX_OVERFLOW)
> +			if (status & CORE_IRQ_MTL_RX_OVERFLOW && priv->hw->dma->set_rx_tail_ptr)
>  				priv->hw->dma->set_rx_tail_ptr(priv->ioaddr,
>  							priv->rx_tail_addr,
>  							STMMAC_CHAN0);
>