netdev - RE: [patch] be2net: signedness bug in be_msix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Jun 2016 16:52:56 +0530
From:	Sathya Perla <sathya.perla@...adcom.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Ajit Kumar Khaparde <ajit.khaparde@...adcom.com>,
	Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
	Somnath Kotur <somnath.kotur@...adcom.com>,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: RE: [patch] be2net: signedness bug in be_msix_enable()

> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@...cle.com]
>
> "num_vec" needs to be signed for the error handling to work.
>
> Fixes: e261768e9e39 ('be2net: support asymmetric rx/tx queue counts')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/emulex/benet/be_main.c
> index 1873c74..1f16e73 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -3251,8 +3251,9 @@ static void be_msix_disable(struct be_adapter
*adapter)
>
>  static int be_msix_enable(struct be_adapter *adapter)  {
> -	unsigned int i, num_vec, max_roce_eqs;
> +	unsigned int i, max_roce_eqs;
>  	struct device *dev = &adapter->pdev->dev;
> +	int num_vec;
>

Oops...thanks for catching this! This must go into net-next.

Acked-by: Sathya Perla <sathya.perla@...adcom.com>