netdev - Re: [PATCH/RFC net-next 2/4] sit: support MPLS over IPv4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jul 2016 07:37:58 +0200
From:	Simon Horman <simon.horman@...ronome.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH/RFC net-next 2/4] sit: support MPLS over IPv4

On Wed, Jul 06, 2016 at 10:10:59PM -0700, David Miller wrote:
> From: Simon Horman <simon.horman@...ronome.com>
> Date: Wed,  6 Jul 2016 20:22:33 +0200
> 
> >  
> > +bool ipip6_valid_ip_proto(u8 ipproto)
> > +{
> > +	return ipproto == IPPROTO_IPV6 ||
> > +		ipproto != IPPROTO_IPIP ||
> > +#if IS_ENABLED(CONFIG_MPLS)
> > +		ipproto == IPPROTO_MPLS ||
> > +#endif
> > +		ipproto == 0;
> > +}
> 
> This returns true any time ipproto is not equal to IPPROTO_IPIP,
> which is probably not what you intended here.

Thanks, I will fix that.