netdev - Re: [Xen-devel] [PATCH] xen-netfront: prefer xenbus_write() over xenbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jul 2016 12:12:24 +0100
From:	David Vrabel <david.vrabel@...rix.com>
To:	Jan Beulich <JBeulich@...e.com>, <david.vrabel@...rix.com>,
	<boris.ostrovsky@...cle.com>, Juergen Gross <JGross@...e.com>
CC:	xen-devel <xen-devel@...ts.xenproject.org>,
	<netdev@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen-netfront: prefer xenbus_write() over
 xenbus_printf() where possible

On 07/07/16 09:00, Jan Beulich wrote:
> ... as being the simpler variant.

It's really annoying that all these related cleanups where not in the
same thread. Don't do this again, please.

The better clean-up is to remove xenbus_write() in favour of
xenbus_printf() everywhere (especially since one of your "cleanups" made
it worse).

xenbus_printf() does everything xenbus_write() can do with no loss of
readability.

David