netdev - RE: [PATCH v2 1/2] libxt_hashlimit: Prepare libxt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D5F4F3704@AcuExch.aculab.com>
Date:	Fri, 8 Jul 2016 16:37:36 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Vishwanath Pai' <vpai@...mai.com>,
	"pablo@...filter.org" <pablo@...filter.org>,
	"kaber@...sh.net" <kaber@...sh.net>,
	"kadlec@...ckhole.kfki.hu" <kadlec@...ckhole.kfki.hu>
CC:	"johunt@...mai.com" <johunt@...mai.com>,
	"netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>,
	"coreteam@...filter.org" <coreteam@...filter.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"pai.vishwain@...il.com" <pai.vishwain@...il.com>
Subject: RE: [PATCH v2 1/2] libxt_hashlimit: Prepare libxt_hashlimit.c for
 revision 2

From: Vishwanath Pai
> Sent: 08 July 2016 00:34
> I am planning to add a revision 2 for the hashlimit xtables module to
> support higher packets per second rates. This patch renames all the
> functions and variables related to revision 1 by adding _v1 at the end of
> the names.

Sounds backwards.
If you need to change the default, and are changing all the callers,
the just change it.

If you think some users would still want 32bit limits, then you should
(probably) use a _64 suffix for the new functions.

	David