netdev - Re: [PATCH v7 01/11] bpf: add XDP prog type for early driver filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2016 23:26:14 -0700
From:	Brenden Blanco <bblanco@...mgrid.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, jhs@...atatu.com,
	saeedm@....mellanox.co.il, kafai@...com, brouer@...hat.com,
	as754m@....com, alexei.starovoitov@...il.com, gerlitz.or@...il.com,
	john.fastabend@...il.com, hannes@...essinduktion.org,
	tgraf@...g.ch, tom@...bertland.com, daniel@...earbox.net
Subject: Re: [PATCH v7 01/11] bpf: add XDP prog type for early driver filter

On Mon, Jul 11, 2016 at 11:02:54PM -0700, David Miller wrote:
> From: Brenden Blanco <bblanco@...mgrid.com>
> Date: Mon, 11 Jul 2016 14:29:48 -0700
> 
> > +	WARN_ONCE(1, "\n"
> > +		     "*****************************************************\n"
> > +		     "**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **\n"
> > +		     "**                                               **\n"
> > +		     "** XDP program returned unknown value %-10u **\n"
> > +		     "**                                               **\n"
> > +		     "** XDP programs must return a well-known return  **\n"
> > +		     "** value. Invalid return values will result in   **\n"
> > +		     "** packet loss.                                  **\n"
> > +		     "**                                               **\n"
> > +		     "**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **\n"
> > +		     "*****************************************************\n",
> 
> This is rediculous.
> 
> The log message should be concise, one line, and not scream things
> like "NOTICE".  That's what the log level is for, to indicate the
> severity of the issue.
Makes sense, and I won't try this approach again. The caller of this
code continues to be much debated as well.