netdev - Re: [PATCH net-next v2 02/10] net/ncsi: NCSI command packet handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Jul 2016 22:08:23 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Gavin Shan <gwshan@...ux.vnet.ibm.com>
Cc:	kbuild-all@...org, netdev@...r.kernel.org, davem@...emloft.net,
	benh@...nel.crashing.org, joel@....id.au, gerlitz.or@...il.com,
	weixue@...stnetic.com, yuvali@...lanox.com,
	alexei.starovoitov@...il.com, f.fainelli@...il.com,
	Gavin Shan <gwshan@...ux.vnet.ibm.com>
Subject: Re: [PATCH net-next v2 02/10] net/ncsi: NCSI command packet handler

Hi,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Gavin-Shan/NCSI-Support/20160715-190549
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/swab.h:4:0,
                    from include/uapi/linux/byteorder/little_endian.h:12,
                    from include/linux/byteorder/little_endian.h:4,
                    from arch/x86/include/uapi/asm/byteorder.h:4,
                    from include/asm-generic/bitops/le.h:5,
                    from arch/x86/include/asm/bitops.h:504,
                    from include/linux/bitops.h:36,
                    from include/linux/kernel.h:10,
                    from include/linux/list.h:8,
                    from include/linux/module.h:9,
                    from net/ncsi/ncsi-cmd.c:10:
   net/ncsi/ncsi-cmd.c: In function 'ncsi_alloc_command':
>> net/ncsi/ncsi-cmd.c:301:24: error: 'ETH_P_NCSI' undeclared (first use in this function)
     skb->protocol = htons(ETH_P_NCSI);
                           ^
   include/uapi/linux/swab.h:100:54: note: in definition of macro '__swab16'
    #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
                                                         ^
>> include/linux/byteorder/generic.h:134:21: note: in expansion of macro '__cpu_to_be16'
    #define ___htons(x) __cpu_to_be16(x)
                        ^~~~~~~~~~~~~
>> include/linux/byteorder/generic.h:140:18: note: in expansion of macro '___htons'
    #define htons(x) ___htons(x)
                     ^~~~~~~~
>> net/ncsi/ncsi-cmd.c:301:18: note: in expansion of macro 'htons'
     skb->protocol = htons(ETH_P_NCSI);
                     ^~~~~
   net/ncsi/ncsi-cmd.c:301:24: note: each undeclared identifier is reported only once for each function it appears in
     skb->protocol = htons(ETH_P_NCSI);
                           ^
   include/uapi/linux/swab.h:100:54: note: in definition of macro '__swab16'
    #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
                                                         ^
>> include/linux/byteorder/generic.h:134:21: note: in expansion of macro '__cpu_to_be16'
    #define ___htons(x) __cpu_to_be16(x)
                        ^~~~~~~~~~~~~
>> include/linux/byteorder/generic.h:140:18: note: in expansion of macro '___htons'
    #define htons(x) ___htons(x)
                     ^~~~~~~~
>> net/ncsi/ncsi-cmd.c:301:18: note: in expansion of macro 'htons'
     skb->protocol = htons(ETH_P_NCSI);
                     ^~~~~
   net/ncsi/ncsi-cmd.c: In function 'ncsi_xmit_cmd':
   net/ncsi/ncsi-cmd.c:347:22: error: 'ETH_P_NCSI' undeclared (first use in this function)
     eh->h_proto = htons(ETH_P_NCSI);
                         ^
   include/uapi/linux/swab.h:100:54: note: in definition of macro '__swab16'
    #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
                                                         ^
>> include/linux/byteorder/generic.h:134:21: note: in expansion of macro '__cpu_to_be16'
    #define ___htons(x) __cpu_to_be16(x)
                        ^~~~~~~~~~~~~
>> include/linux/byteorder/generic.h:140:18: note: in expansion of macro '___htons'
    #define htons(x) ___htons(x)
                     ^~~~~~~~
   net/ncsi/ncsi-cmd.c:347:16: note: in expansion of macro 'htons'
     eh->h_proto = htons(ETH_P_NCSI);
                   ^~~~~

vim +/ETH_P_NCSI +301 net/ncsi/ncsi-cmd.c

   295	
   296		nr->cmd = skb;
   297		skb_reserve(skb, hlen);
   298		skb_reset_network_header(skb);
   299	
   300		skb->dev = dev;
 > 301		skb->protocol = htons(ETH_P_NCSI);
   302	
   303		return nr;
   304	}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (55093 bytes)