netdev - Re: [PATCH -next] drivers: net: phy: xgene: Remove redundant dev_err call in xgene_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Jul 2016 13:42:18 -0700
From:	Iyappan Subramanian <isubramanian@....com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	Keyur Chudgar <kchudgar@....com>,
	Florian Fainelli <f.fainelli@...il.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH -next] drivers: net: phy: xgene: Remove redundant dev_err
 call in xgene_mdio_probe()

On Wed, Jul 27, 2016 at 7:12 PM, Wei Yongjun <weiyj.lk@...il.com> wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyj.lk@...il.com>
> ---
>  drivers/net/phy/mdio-xgene.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/phy/mdio-xgene.c b/drivers/net/phy/mdio-xgene.c
> index d94a978..7756748 100644
> --- a/drivers/net/phy/mdio-xgene.c
> +++ b/drivers/net/phy/mdio-xgene.c
> @@ -345,10 +345,8 @@ static int xgene_mdio_probe(struct platform_device *pdev)
>
>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>         csr_base = devm_ioremap_resource(dev, res);
> -       if (IS_ERR(csr_base)) {
> -               dev_err(dev, "Unable to retrieve mac CSR region\n");
> +       if (IS_ERR(csr_base))
>                 return PTR_ERR(csr_base);
> -       }
>         pdata->mac_csr_addr = csr_base;
>         pdata->mdio_csr_addr = csr_base + BLOCK_XG_MDIO_CSR_OFFSET;
>         pdata->diag_csr_addr = csr_base + BLOCK_DIAG_CSR_OFFSET;
>
>
>

Thanks.

Acked-By: Iyappan Subramanian <isubramanian@....com>